From be268ace427f763b191d47141634ee41badd1dbc Mon Sep 17 00:00:00 2001
From: benbierens <thatbenbierens@gmail.com>
Date: Mon, 1 Apr 2024 13:21:21 +0200
Subject: [PATCH] Find bug in blocktime finder

---
 .../CodexTests/BasicTests/MarketplaceTests.cs |  4 ---
 .../NethereumWorkflow/BlockTimeFinderTests.cs | 35 +++++++++++++++++++
 2 files changed, 35 insertions(+), 4 deletions(-)

diff --git a/Tests/CodexTests/BasicTests/MarketplaceTests.cs b/Tests/CodexTests/BasicTests/MarketplaceTests.cs
index 79afa43..1a54f14 100644
--- a/Tests/CodexTests/BasicTests/MarketplaceTests.cs
+++ b/Tests/CodexTests/BasicTests/MarketplaceTests.cs
@@ -71,8 +71,6 @@ namespace CodexTests.BasicTests
                         .AsStorageNode()
                         .AsValidator()));
 
-                AssertBalance(contracts, seller, Is.EqualTo(sellerInitialBalance));
-
                 var availability = new StorageAvailability(
                     totalSpace: 10.GB(),
                     maxDuration: TimeSpan.FromMinutes(30),
@@ -90,8 +88,6 @@ namespace CodexTests.BasicTests
                     .WithAccount(myAccount)
                     .WithInitial(10.Eth(), buyerInitialBalance)));
 
-            AssertBalance(contracts, buyer, Is.EqualTo(buyerInitialBalance));
-
             var contentId = buyer.UploadFile(testFile);
 
             var purchase = new StoragePurchaseRequest(contentId)
diff --git a/Tests/FrameworkTests/NethereumWorkflow/BlockTimeFinderTests.cs b/Tests/FrameworkTests/NethereumWorkflow/BlockTimeFinderTests.cs
index 5653b45..1c51084 100644
--- a/Tests/FrameworkTests/NethereumWorkflow/BlockTimeFinderTests.cs
+++ b/Tests/FrameworkTests/NethereumWorkflow/BlockTimeFinderTests.cs
@@ -117,6 +117,41 @@ namespace FrameworkTests.NethereumWorkflow
 
             Assert.That(notFound, Is.Null);
         }
+
+        [Test]
+        public void FailsToFindBlockBeforeFrontOfChain_history()
+        {
+            var first = blocks.First().Value;
+
+            var notFound = finder.GetHighestBlockNumberBefore(first.JustBefore);
+
+            Assert.That(notFound, Is.Null);
+        }
+
+        [Test]
+        public void FailsToFindBlockAfterTailOfChain_future()
+        {
+            var last = blocks.Last().Value;
+
+            var notFound = finder.GetLowestBlockNumberAfter(last.JustAfter);
+
+            Assert.That(notFound, Is.Null);
+        }
+
+        [Test]
+        public void RunThrough()
+        {
+            foreach (var pair in blocks)
+            {
+                finder.GetHighestBlockNumberBefore(pair.Value.JustBefore);
+                finder.GetHighestBlockNumberBefore(pair.Value.Time);
+                finder.GetHighestBlockNumberBefore(pair.Value.JustAfter);
+
+                finder.GetLowestBlockNumberAfter(pair.Value.JustBefore);
+                finder.GetLowestBlockNumberAfter(pair.Value.Time);
+                finder.GetLowestBlockNumberAfter(pair.Value.JustAfter);
+            }
+        }
     }
 
     public class Block