codex-storage
/
constantine
mirror of https://github.com/codex-storage/constantine.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove TODO comment about bound checking, UncheckedArray in the raw API are not bound checked

This commit is contained in:
Mamy André-Ratsimbazafy 2020-02-12 00:33:12 +01:00
parent 89fce3b1c4
commit 343399ba1c
No known key found for this signature in database
GPG Key ID: 7B88AD1FE79492E1
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
constantine/math/bigints_raw.nim
View File

@ -84,7 +84,11 @@ type
## otherwise each bigint routines would have an instantiation for ## otherwise each bigint routines would have an instantiation for
## each static `bits` parameter. ## each static `bits` parameter.
## - while not forcing the caller to preallocate computation buffers ## - while not forcing the caller to preallocate computation buffers
## for the high-level API ## for the high-level API and enforcing bitsizes
## - avoids runtime bound-checks on the view
## for performance
## and to ensure exception-free code
## even when compiled in non "-d:danger" mode
## ##
## As with the BigInt type: ## As with the BigInt type:
## - "bitLength" is the internal bitlength of the integer ## - "bitLength" is the internal bitlength of the integer
@ -240,8 +244,6 @@ func sub*(a: BigIntViewMut, b: BigIntViewAny, ctl: CTBool[Word]): CTBool[Word] =
# #
# ############################################################ # ############################################################
# TODO: push boundsCheck off. They would be extremely costly.
func shlAddMod(a: BigIntViewMut, c: Word, M: BigIntViewConst) = func shlAddMod(a: BigIntViewMut, c: Word, M: BigIntViewConst) =
## Fused modular left-shift + add ## Fused modular left-shift + add
## Shift input `a` by a word and add `c` modulo `M` ## Shift input `a` by a word and add `c` modulo `M`