From c4d5c6e8644176892053278f91957a3727ca71aa Mon Sep 17 00:00:00 2001
From: Arnaud <arnaud@status.im>
Date: Thu, 22 Aug 2024 20:04:24 +0200
Subject: [PATCH] Add events to be tracked by the Storybook while interacting
 with the components

---
 src/components/Button/Button.tsx         |  8 +++++
 src/components/ButtonIcon/ButtonIcon.tsx |  8 +++++
 src/components/Dropdown/Dropdown.tsx     | 32 +++++++++++++++----
 src/components/Input/Input.tsx           | 12 +++++++
 src/components/InputGroup/InputGroup.tsx | 18 ++++++++++-
 src/components/InputGroup/inputGroup.css |  2 +-
 src/components/Select/Select.tsx         | 16 ++++++++++
 src/components/Table/Table.tsx           |  1 -
 src/components/Upload/Upload.tsx         | 30 +++++++++++++++---
 stories/Button.stories.ts                |  6 +++-
 stories/ButtonIcon.stories.ts            |  2 +-
 stories/Dropdown.stories.tsx             | 40 +++++++++++++++++++-----
 stories/Input.stories.ts                 |  8 ++++-
 stories/InputGroup.stories.ts            |  9 +++++-
 stories/Select.stories.ts                |  8 ++++-
 stories/Stepper.stories.tsx              | 12 +++++--
 stories/Upload.stories.tsx               | 32 ++++++++++++++++---
 17 files changed, 211 insertions(+), 33 deletions(-)

diff --git a/src/components/Button/Button.tsx b/src/components/Button/Button.tsx
index 63408f0..0cae94d 100644
--- a/src/components/Button/Button.tsx
+++ b/src/components/Button/Button.tsx
@@ -23,6 +23,10 @@ type Props = {
 
   onClick?: () => unknown | Promise<unknown>;
 
+  onMouseEnter?: () => unknown | Promise<unknown>;
+
+  onMouseLeave?: () => unknown | Promise<unknown>;
+
   label: string;
 
   /**
@@ -67,6 +71,8 @@ export function Button({
   label,
   className = "",
   Icon,
+  onMouseEnter,
+  onMouseLeave,
   fetching = false,
   disabled = false,
   style,
@@ -76,6 +82,8 @@ export function Button({
   return (
     <button
       onClick={onClick}
+      onMouseEnter={onMouseEnter}
+      onMouseLeave={onMouseLeave}
       style={style}
       className={`button ${className} button--${variant}`}
       {...attributes({
diff --git a/src/components/ButtonIcon/ButtonIcon.tsx b/src/components/ButtonIcon/ButtonIcon.tsx
index ffe430a..43965c5 100644
--- a/src/components/ButtonIcon/ButtonIcon.tsx
+++ b/src/components/ButtonIcon/ButtonIcon.tsx
@@ -15,6 +15,10 @@ type Props = {
 
   onClick?: () => void;
 
+  onMouseEnter?: () => unknown | Promise<unknown>;
+
+  onMouseLeave?: () => unknown | Promise<unknown>;
+
   disabled?: boolean;
 
   /**
@@ -32,12 +36,16 @@ export function ButtonIcon({
   Icon,
   onClick,
   style,
+  onMouseEnter,
+  onMouseLeave,
   disabled = false,
   variant = "big",
 }: Props) {
   return (
     <button
       className={`buttonIcon buttonIcon--${variant}`}
+      onMouseEnter={onMouseEnter}
+      onMouseLeave={onMouseLeave}
       onClick={onClick}
       style={style}
       {...attributes({ disabled: disabled, "aria-disabled": disabled })}
diff --git a/src/components/Dropdown/Dropdown.tsx b/src/components/Dropdown/Dropdown.tsx
index f0f839f..1cac863 100644
--- a/src/components/Dropdown/Dropdown.tsx
+++ b/src/components/Dropdown/Dropdown.tsx
@@ -52,6 +52,14 @@ type Props = {
    */
   onSelected?: (o: DropdownOption) => void;
 
+  onBlur?: () => void;
+
+  onFocus?: () => void;
+
+  onMouseEnter?: () => void;
+
+  onMouseLeave?: () => void;
+
   /**
    * Apply custom css variables.
    * --codex-dropdown-panel-background
@@ -65,6 +73,10 @@ export function Dropdown({
   placeholder,
   style,
   options,
+  onMouseEnter,
+  onMouseLeave,
+  onFocus,
+  onBlur,
   onChange,
   onSelected,
   value = "",
@@ -78,11 +90,17 @@ export function Dropdown({
   );
   const [focused, setFocused] = useState(false);
 
-  const onFocus = () => setFocused(true);
+  const onInternalFocus = () => {
+    setFocused(true);
+    onFocus?.();
+  };
 
-  const onBlur = () => () => window.setTimeout(() => setFocused(false), 150);
+  const onInternalBlur = () => {
+    onBlur?.();
+    window.setTimeout(() => setFocused(false), 150);
+  };
 
-  const onClick = (o: DropdownOption) => {
+  const onSelect = (o: DropdownOption) => {
     onSelected?.(o);
     setFocused(false);
   };
@@ -98,12 +116,14 @@ export function Dropdown({
       <Input
         className="dropdown-input"
         onChange={onChange}
-        onFocus={onFocus}
-        onBlur={onBlur}
+        onFocus={onInternalFocus}
+        onBlur={onInternalBlur}
         placeholder={placeholder}
         value={value}
         label={""}
         id={""}
+        onMouseEnter={onMouseEnter}
+        onMouseLeave={onMouseLeave}
       />
 
       <div className="dropdown-panel" {...attr}>
@@ -111,7 +131,7 @@ export function Dropdown({
           filtered.map((o) => (
             <div
               className="dropdown-option"
-              onClick={() => onClick(o)}
+              onClick={() => onSelect(o)}
               key={o.title}
             >
               {o.Icon && <o.Icon />}
diff --git a/src/components/Input/Input.tsx b/src/components/Input/Input.tsx
index 7d60b39..a799938 100644
--- a/src/components/Input/Input.tsx
+++ b/src/components/Input/Input.tsx
@@ -27,6 +27,12 @@ type Props = {
 
   onBlur?: () => unknown | Promise<unknown>;
 
+  onClick?: (() => void) | undefined;
+
+  onMouseEnter?: () => void;
+
+  onMouseLeave?: () => void;
+
   placeholder?: string;
 
   value?: string;
@@ -74,6 +80,9 @@ export function Input({
   onFocus,
   placeholder,
   onChange,
+  onMouseEnter,
+  onMouseLeave,
+  onClick,
   className,
   style,
   Icon,
@@ -95,6 +104,9 @@ export function Input({
           </div>
         )}
         <input
+          onClick={onClick}
+          onMouseEnter={onMouseEnter}
+          onMouseLeave={onMouseLeave}
           className={classnames(
             ["input"],
             ["input-icon-input", !!Icon],
diff --git a/src/components/InputGroup/InputGroup.tsx b/src/components/InputGroup/InputGroup.tsx
index 7020405..b798f3e 100644
--- a/src/components/InputGroup/InputGroup.tsx
+++ b/src/components/InputGroup/InputGroup.tsx
@@ -43,6 +43,14 @@ type Props = {
    */
   onGroupChange?: (e: ChangeEvent<HTMLSelectElement>) => void;
 
+  onBlur?: () => void;
+
+  onFocus?: () => void;
+
+  onMouseEnter?: () => void;
+
+  onMouseLeave?: () => void;
+
   id: string;
 
   step?: string;
@@ -63,9 +71,13 @@ export function InputGroup({
   className,
   onChange,
   onGroupChange,
+  onMouseEnter,
+  onMouseLeave,
+  onFocus,
+  onBlur,
   id,
   step,
-  value = "",
+  value = undefined,
   groupValue = "",
 }: Props) {
   return (
@@ -81,6 +93,10 @@ export function InputGroup({
               type={type}
               value={value}
               step={step}
+              onMouseEnter={onMouseEnter}
+              onMouseLeave={onMouseLeave}
+              onFocus={onFocus}
+              onBlur={onBlur}
             />
           </div>
 
diff --git a/src/components/InputGroup/inputGroup.css b/src/components/InputGroup/inputGroup.css
index 8e20f3c..076e8ec 100644
--- a/src/components/InputGroup/inputGroup.css
+++ b/src/components/InputGroup/inputGroup.css
@@ -26,7 +26,7 @@ select.inputGroup-select {
   border-top-right-radius: var(--codex-border-radius);
   border-bottom-right-radius: var(--codex-border-radius);
   background-color: var(--codex-border-color);
-  padding: 0.75rem;
+  padding: calc(0.5rem + 0.5px);
 }
 
 .inputGroup-inputContainer {
diff --git a/src/components/Select/Select.tsx b/src/components/Select/Select.tsx
index 857eac3..de2763e 100644
--- a/src/components/Select/Select.tsx
+++ b/src/components/Select/Select.tsx
@@ -24,6 +24,14 @@ type Props = {
    */
   onChange?: (e: ChangeEvent<HTMLSelectElement>) => void | Promise<void>;
 
+  onFocus?: () => void | Promise<void>;
+
+  onBlur?: () => unknown | Promise<unknown>;
+
+  onMouseEnter?: () => void;
+
+  onMouseLeave?: () => void;
+
   /**
    * Apply custom css variables.
    */
@@ -39,6 +47,10 @@ export function Select({
   id,
   options,
   onChange,
+  onBlur,
+  onFocus,
+  onMouseEnter,
+  onMouseLeave,
   style,
   className,
   defaultValue,
@@ -53,6 +65,10 @@ export function Select({
           id={id}
           className={`select ${className}`}
           onChange={onChange}
+          onBlur={onBlur}
+          onFocus={onFocus}
+          onMouseEnter={onMouseEnter}
+          onMouseLeave={onMouseLeave}
           style={style}
           defaultValue={defaultValue}
         >
diff --git a/src/components/Table/Table.tsx b/src/components/Table/Table.tsx
index bdaca55..ac93d52 100644
--- a/src/components/Table/Table.tsx
+++ b/src/components/Table/Table.tsx
@@ -1,4 +1,3 @@
-import { ReactNode } from "react";
 import "./Table.css";
 import { CellRender } from "./CellRender";
 
diff --git a/src/components/Upload/Upload.tsx b/src/components/Upload/Upload.tsx
index ae90759..a01d5a1 100644
--- a/src/components/Upload/Upload.tsx
+++ b/src/components/Upload/Upload.tsx
@@ -32,12 +32,23 @@ type Props = {
    */
   onSuccess?: (cid: string) => void;
 
+  /*
+   * Event triggered when the user selected files to upload.
+   */
+  onFileChange?: (e: ChangeEvent<HTMLInputElement>) => void;
+
   /**
    * Event triggered when a file is deleted.
    * The id is generated after the file are selected by the user.
    */
   onDeleteItem?: (id: string) => void;
 
+  onClick?: (() => void) | undefined;
+
+  onMouseEnter?: () => void;
+
+  onMouseLeave?: () => void;
+
   /**
    * Allow to override the previous file(s).
    * If false, the user cannot upload a new file(s) until he deletes the previous file(s).
@@ -86,6 +97,10 @@ const defaultProvider = () =>
   );
 
 export function Upload({
+  onMouseEnter,
+  onMouseLeave,
+  onClick,
+  onFileChange,
   multiple = true,
   editable = true,
   onDeleteItem,
@@ -109,7 +124,7 @@ export function Upload({
     uploadFiles(e.dataTransfer.files);
   };
 
-  const onFileChange = (e: ChangeEvent<HTMLInputElement>) => {
+  const onInternalFileChange = (e: ChangeEvent<HTMLInputElement>) => {
     if (e.target.files) {
       uploadFiles(e.target.files);
     }
@@ -117,6 +132,8 @@ export function Upload({
     if (input.current) {
       input.current.value = "";
     }
+
+    onFileChange?.(e);
   };
 
   const onClose = (id: string) => {
@@ -124,17 +141,22 @@ export function Upload({
     onDeleteItem?.(id);
   };
 
-  const onClick = () => input.current?.click();
+  const onInternalClick = () => {
+    onClick?.();
+    input.current?.click();
+  };
 
   return (
     <>
       <div
         className={classnames(["upload"], ["upload-warning", !!warning])}
         tabIndex={1}
-        onClick={onClick}
+        onClick={onInternalClick}
         onDragOver={onDragPrevents}
         onDragEnter={onDragPrevents}
         onDrop={onDrop}
+        onMouseEnter={onMouseEnter}
+        onMouseLeave={onMouseLeave}
       >
         <ButtonIcon Icon={multiple ? FileStack : UploadIcon}></ButtonIcon>
         <div className="upload-text">
@@ -152,7 +174,7 @@ export function Upload({
           type="file"
           hidden
           ref={input}
-          onChange={onFileChange}
+          onChange={onInternalFileChange}
           {...attributes({ multiple: multiple })}
         />
 
diff --git a/stories/Button.stories.ts b/stories/Button.stories.ts
index d5024e5..b10a536 100644
--- a/stories/Button.stories.ts
+++ b/stories/Button.stories.ts
@@ -20,7 +20,11 @@ const meta = {
     },
   },
   // Use `fn` to spy on the onClick arg, which will appear in the actions panel once invoked: https://storybook.js.org/docs/essentials/actions#action-args
-  args: { onClick: fn() },
+  args: {
+    onClick: fn(),
+    onMouseEnter: fn(),
+    onMouseLeave: fn(),
+  },
 } satisfies Meta<typeof Button>;
 
 export default meta;
diff --git a/stories/ButtonIcon.stories.ts b/stories/ButtonIcon.stories.ts
index bdcce2a..830fb88 100644
--- a/stories/ButtonIcon.stories.ts
+++ b/stories/ButtonIcon.stories.ts
@@ -15,7 +15,7 @@ const meta = {
       control: { type: "select" },
     },
   },
-  args: { onClick: fn() },
+  args: { onClick: fn(), onMouseEnter: fn(), onMouseLeave: fn() },
 } satisfies Meta<typeof ButtonIcon>;
 
 export default meta;
diff --git a/stories/Dropdown.stories.tsx b/stories/Dropdown.stories.tsx
index 817b0ce..5227c3c 100644
--- a/stories/Dropdown.stories.tsx
+++ b/stories/Dropdown.stories.tsx
@@ -3,6 +3,7 @@ import { Dropdown, DropdownOption } from "../src/components/Dropdown/Dropdown";
 import { PdfIcon } from "../src/components/WebFileIcon/PdfIcon";
 import { ImageIcon } from "../src/components/WebFileIcon/ImageIcon";
 import { ChangeEvent, useState } from "react";
+import { fn } from "@storybook/test";
 
 const meta = {
   title: "Forms/Dropdown",
@@ -12,20 +13,46 @@ const meta = {
   },
   tags: ["autodocs"],
   argTypes: {},
+  args: {
+    onChange: fn(),
+    onSelected: fn(),
+    onFocus: fn(),
+    onBlur: fn(),
+    onMouseEnter: fn(),
+    onMouseLeave: fn(),
+  },
 } satisfies Meta<typeof Dropdown>;
 
 export default meta;
 type Story = StoryObj<typeof meta>;
 
-const Template = () => {
-  const [value, setValue] = useState<string>("");
-  const onChange = (e: ChangeEvent<HTMLInputElement>) =>
-    setValue(e.currentTarget.value);
+type Props = {
+  onChange: (e: ChangeEvent<HTMLInputElement>) => void;
 
-  const onSelected = (o: DropdownOption) => setValue(o.title);
+  onSelected?: (o: DropdownOption) => void;
+
+  onClick?: () => void;
+
+  onMouseEnter?: () => void;
+
+  onBlur?: () => void;
+};
+
+const Template = (p: Props) => {
+  const [value, setValue] = useState<string>("");
+  const onChange = (e: ChangeEvent<HTMLInputElement>) => {
+    p.onChange(e);
+    setValue(e.currentTarget.value);
+  };
+
+  const onSelected = (o: DropdownOption) => {
+    setValue(o.title);
+    p.onSelected?.(o);
+  };
 
   return (
     <Dropdown
+      {...p}
       placeholder="Select your file"
       onChange={onChange}
       onSelected={onSelected}
@@ -46,7 +73,7 @@ const Template = () => {
   );
 };
 
-export const Default = Template.bind({});
+export const Default = Template;
 
 export const CustomStyle: Story = {
   args: {
@@ -54,6 +81,5 @@ export const CustomStyle: Story = {
     options: [],
     style: { "--codex-input-border": "1px solid red" },
     value: "",
-    onChange: () => "",
   },
 };
diff --git a/stories/Input.stories.ts b/stories/Input.stories.ts
index ef2e8bd..f373818 100644
--- a/stories/Input.stories.ts
+++ b/stories/Input.stories.ts
@@ -11,7 +11,13 @@ const meta = {
   },
   tags: ["autodocs"],
   argTypes: {},
-  args: { onChange: fn() },
+  args: {
+    onFocus: fn(),
+    onBlur: fn(),
+    onMouseEnter: fn(),
+    onMouseLeave: fn(),
+    onChange: fn(),
+  },
 } satisfies Meta<typeof Input>;
 
 export default meta;
diff --git a/stories/InputGroup.stories.ts b/stories/InputGroup.stories.ts
index 1669346..8408eeb 100644
--- a/stories/InputGroup.stories.ts
+++ b/stories/InputGroup.stories.ts
@@ -10,7 +10,14 @@ const meta = {
   },
   tags: ["autodocs"],
   argTypes: {},
-  args: { onChange: fn() },
+  args: {
+    onGroupChange: fn(),
+    onChange: fn(),
+    onFocus: fn(),
+    onBlur: fn(),
+    onMouseEnter: fn(),
+    onMouseLeave: fn(),
+  },
 } satisfies Meta<typeof InputGroup>;
 
 export default meta;
diff --git a/stories/Select.stories.ts b/stories/Select.stories.ts
index 0239348..284c90a 100644
--- a/stories/Select.stories.ts
+++ b/stories/Select.stories.ts
@@ -10,7 +10,13 @@ const meta = {
   },
   tags: ["autodocs"],
   argTypes: {},
-  args: { onChange: fn() },
+  args: {
+    onFocus: fn(),
+    onBlur: fn(),
+    onMouseEnter: fn(),
+    onMouseLeave: fn(),
+    onChange: fn(),
+  },
 } satisfies Meta<typeof Select>;
 
 export default meta;
diff --git a/stories/Stepper.stories.tsx b/stories/Stepper.stories.tsx
index 0e0a12a..d7e203e 100644
--- a/stories/Stepper.stories.tsx
+++ b/stories/Stepper.stories.tsx
@@ -1,6 +1,7 @@
 import type { Meta, StoryObj } from "@storybook/react";
 import { Stepper } from "../src/components/Stepper/Stepper";
 import React, { useState } from "react";
+import { fn } from "@storybook/test";
 
 const meta = {
   title: "Advanced/Stepper",
@@ -10,13 +11,16 @@ const meta = {
   },
   tags: ["autodocs"],
   argTypes: {},
-  //   args: { onClick: fn() },
+  args: { onChangeStep: fn() },
 } satisfies Meta<typeof Stepper>;
 
 export default meta;
-type Story = StoryObj<typeof meta>;
 
-const Template = () => {
+type Props = {
+  onChangeStep: (s: number, state: "before" | "end") => void | Promise<void>;
+};
+
+const Template = (p: Props) => {
   const [step, setStep] = useState(0);
   const [progress, setProgress] = useState(false);
 
@@ -24,6 +28,8 @@ const Template = () => {
   const title = titles[step];
 
   const onChangeStep = (newStep: number, event: "before" | "end") => {
+    p.onChangeStep(newStep, event);
+
     if (event === "before") {
       setProgress(true);
       return;
diff --git a/stories/Upload.stories.tsx b/stories/Upload.stories.tsx
index df74034..eb2c88c 100644
--- a/stories/Upload.stories.tsx
+++ b/stories/Upload.stories.tsx
@@ -2,6 +2,7 @@ import type { Meta } from "@storybook/react";
 import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
 import { UploadResponse } from "@codex/sdk-js";
 import { Upload } from "../src/components/Upload/Upload";
+import { fn } from "@storybook/test";
 
 const meta = {
   title: "Advanced/Upload",
@@ -11,16 +12,36 @@ const meta = {
   },
   tags: ["autodocs"],
   argTypes: {},
+  args: {
+    onMouseEnter: fn(),
+    onMouseLeave: fn(),
+    onClick: fn(),
+    onSuccess: fn(),
+    onDeleteItem: fn(),
+    onFileChange: fn(),
+  },
 } satisfies Meta<typeof Upload>;
 
 export default meta;
 
 const queryClient = new QueryClient();
 
-const Template = () => {
+type Props = {
+  onClick?: () => void;
+
+  onMouseEnter?: () => void;
+
+  onMouseLeave?: () => void;
+
+  onSuccess?: () => void;
+
+  onDeletedItem?: () => void;
+};
+
+const Template = (p: Props) => {
   return (
     <QueryClientProvider client={queryClient}>
-      {<Upload useWorker={false} multiple />}
+      {<Upload useWorker={false} multiple {...p} />}
     </QueryClientProvider>
   );
 };
@@ -59,11 +80,11 @@ const slowProvider = () =>
     }
   );
 
-const SlowTemplate = () => {
+const SlowTemplate = (p: Props) => {
   return (
     <div className="demo">
       <QueryClientProvider client={queryClient}>
-        {<Upload useWorker={false} multiple provider={slowProvider} />}
+        {<Upload useWorker={false} multiple provider={slowProvider} {...p} />}
       </QueryClientProvider>
     </div>
   );
@@ -71,7 +92,7 @@ const SlowTemplate = () => {
 
 export const Slow = SlowTemplate.bind({});
 
-const SingleTemplate = () => {
+const SingleTemplate = (p: Props) => {
   return (
     <div className="demo">
       <QueryClientProvider client={queryClient}>
@@ -81,6 +102,7 @@ const SingleTemplate = () => {
             multiple={false}
             editable={false}
             provider={slowProvider}
+            {...p}
           />
         }
       </QueryClientProvider>