From df219c85d70cf0fbc1b97b0a7a275accb0ab49c7 Mon Sep 17 00:00:00 2001 From: Eric Mastro Date: Wed, 21 Jun 2023 17:54:41 +1000 Subject: [PATCH] copy slotIndex before delete for emit --- contracts/Marketplace.sol | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/contracts/Marketplace.sol b/contracts/Marketplace.sol index d7e2f2e..fa088b4 100644 --- a/contracts/Marketplace.sol +++ b/contracts/Marketplace.sol @@ -110,7 +110,7 @@ contract Marketplace is Proofs, StateRetrieval { _addToMySlots(slot.host, slotId); - emit SlotFilled(requestId, slotIndex, slotId); + emit SlotFilled(requestId, slotIndex); if (context.slotsFilled == request.ask.slots) { context.state = RequestState.Started; context.startedAt = block.timestamp; @@ -160,9 +160,10 @@ contract Marketplace is Proofs, StateRetrieval { _removeFromMySlots(slot.host, slotId); + uint256 slotIndex = slot.slotIndex; delete _slots[slotId]; context.slotsFilled -= 1; - emit SlotFreed(requestId, slot.slotIndex, slotId); + emit SlotFreed(requestId, slotIndex); resetMissingProofs(slotId); Request storage request = _requests[requestId]; @@ -316,13 +317,11 @@ contract Marketplace is Proofs, StateRetrieval { event RequestFailed(RequestId indexed requestId); event SlotFilled( RequestId indexed requestId, - uint256 indexed slotIndex, - SlotId slotId + uint256 slotIndex ); event SlotFreed( RequestId indexed requestId, - uint256 slotIndex, - SlotId slotId + uint256 slotIndex ); event RequestCancelled(RequestId indexed requestId);